Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Header): Allow opening and closing to toggle the Mega Menu #1892

Closed
wants to merge 1 commit into from

Conversation

VincentSmedinga
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

Allows a parent component to open or close the Header.

Why

The Header should close after clicking a link in the Mega Menu.

How

  • Rename the local state variable from open to isOpen
  • Add an open prop and an onClose callback

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • n/a

@VincentSmedinga VincentSmedinga requested a review from dlnr February 27, 2025 19:07
@VincentSmedinga VincentSmedinga requested a review from a team as a code owner February 27, 2025 19:07
@github-actions github-actions bot temporarily deployed to demo-control-open-header February 27, 2025 19:08 Destroyed
@VincentSmedinga VincentSmedinga changed the title deat: Allow opening and closing Mega Menu in Header deat: Allow opening and closing the Header to show or hide the Mega Menu Feb 27, 2025
@VincentSmedinga VincentSmedinga changed the title deat: Allow opening and closing the Header to show or hide the Mega Menu feat(Header): Allow opening and closing to show or hide the Mega Menu Feb 27, 2025
@VincentSmedinga VincentSmedinga changed the title feat(Header): Allow opening and closing to show or hide the Mega Menu feat(Header): Allow opening and closing and toggle the Mega Menu Feb 27, 2025
@VincentSmedinga VincentSmedinga changed the title feat(Header): Allow opening and closing and toggle the Mega Menu feat(Header): Allow opening and closing to toggle the Mega Menu Feb 27, 2025
@VincentSmedinga
Copy link
Contributor Author

We decided this is not a responsibility of the design system but of the application framework that changes the browser’s default behavior.

We resolved this in our Prototypes application with a Next.js Template.

@VincentSmedinga VincentSmedinga deleted the feat/control-open-header branch February 28, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant