Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Page Menu): Deprecate Page Menu component #1891

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

VincentSmedinga
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

Marks our Page Menu component as deprecated.

Why

The Header and Footer components now implement their own menus.

How

n/a

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • n/a

@VincentSmedinga VincentSmedinga requested a review from dlnr February 27, 2025 13:32
@VincentSmedinga VincentSmedinga requested a review from a team as a code owner February 27, 2025 13:32
@github-actions github-actions bot temporarily deployed to demo-deprecate-page-menu February 27, 2025 13:32 Destroyed
dlnr
dlnr previously approved these changes Feb 27, 2025
Co-authored-by: Aram <37216945+alimpens@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to demo-deprecate-page-menu February 28, 2025 13:36 Destroyed
@github-actions github-actions bot temporarily deployed to demo-deprecate-page-menu February 28, 2025 14:45 Destroyed
@VincentSmedinga VincentSmedinga changed the title feat: Deprecate Page Menu feat(Page Menu): Deprecate Page Menu component Feb 28, 2025
@alimpens alimpens enabled auto-merge (squash) February 28, 2025 15:51
@github-actions github-actions bot temporarily deployed to demo-deprecate-page-menu February 28, 2025 15:51 Destroyed
@alimpens alimpens merged commit 71ce759 into develop Feb 28, 2025
6 checks passed
@alimpens alimpens deleted the feat/deprecate-page-menu branch February 28, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants