Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Header)!: Add responsive version of Amsterdam Logo, remove Heading level 1 #1880

Merged
merged 30 commits into from
Mar 7, 2025

Conversation

alimpens
Copy link
Contributor

@alimpens alimpens commented Feb 19, 2025

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

Only show the emblem of the logo on narrow screens.

Why

It is in the original design, we didn't implement it yet.

How

By cutting of the text part of the logo using CSS.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

@alimpens alimpens requested a review from a team as a code owner February 19, 2025 10:57
@alimpens alimpens requested review from dlnr and RubenSibon February 19, 2025 10:57
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo February 19, 2025 10:58 Destroyed
alimpens and others added 2 commits February 19, 2025 13:58
Co-authored-by: Vincent Smedinga <v.smedinga@amsterdam.nl>
Co-authored-by: Vincent Smedinga <v.smedinga@amsterdam.nl>
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo February 19, 2025 12:58 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo February 19, 2025 13:01 Destroyed
@VincentSmedinga VincentSmedinga changed the title feat: Add responsive version of Amsterdam Logo in Header feat(Header): Add responsive version of Amsterdam Logo Feb 25, 2025
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo February 26, 2025 08:45 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo February 26, 2025 09:00 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo February 26, 2025 09:02 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo February 28, 2025 15:10 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo February 28, 2025 15:12 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo February 28, 2025 15:27 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo February 28, 2025 15:31 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo February 28, 2025 16:04 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo March 5, 2025 08:38 Destroyed
@alimpens alimpens requested a review from VincentSmedinga March 5, 2025 12:20
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo March 7, 2025 13:37 Destroyed
…into feat/DES-978-add-responsive-header-logo
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo March 7, 2025 13:40 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo March 7, 2025 13:55 Destroyed
Co-authored-by: Vincent Smedinga <v.smedinga@amsterdam.nl>
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo March 7, 2025 14:00 Destroyed
@alimpens alimpens changed the title feat(Header): Add responsive version of Amsterdam Logo feat(Header)!: Add responsive version of Amsterdam Logo, remove Heading level 1 Mar 7, 2025
Co-authored-by: Vincent Smedinga <v.smedinga@amsterdam.nl>
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo March 7, 2025 14:03 Destroyed
@VincentSmedinga VincentSmedinga enabled auto-merge (squash) March 7, 2025 14:08
@github-actions github-actions bot temporarily deployed to demo-DES-978-add-responsive-header-logo March 7, 2025 14:08 Destroyed
@VincentSmedinga VincentSmedinga merged commit 7de8138 into develop Mar 7, 2025
6 checks passed
@VincentSmedinga VincentSmedinga deleted the feat/DES-978-add-responsive-header-logo branch March 7, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants