Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Badge)!: Remove some colour options #1826

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

VincentSmedinga
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

This removes the possibility of making a Badge blue (it is not interactive) or neutral (we don’t have tokens for these options). The remaining colours are in the ‘highlight’ and ‘feedback’ groups that #1820 will introduce.

Why

See above.

How

n/a

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • n/a

@VincentSmedinga VincentSmedinga requested a review from a team as a code owner January 20, 2025 22:44
@github-actions github-actions bot temporarily deployed to demo-DES-1150-tighten-badge-colours January 22, 2025 15:23 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1150-tighten-badge-colours January 24, 2025 12:34 Destroyed
@alimpens alimpens enabled auto-merge (squash) January 24, 2025 12:34
@alimpens alimpens merged commit 1325e1b into develop Jan 24, 2025
6 checks passed
@alimpens alimpens deleted the feat/DES-1150-tighten-badge-colours branch January 24, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants