feat(Pagination)!: Use links instead of buttons #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-DES-1024-pagination-links-instead-of-buttons
github-actions
bot
temporarily deployed
to
demo-DES-1024-pagination-links-instead-of-buttons
VincentSmedinga
changed the title
Co-authored-by: Vincent Smedinga <v.smedinga@amsterdam.nl>
github-actions
bot
temporarily deployed
to
demo-DES-1024-pagination-links-instead-of-buttons
Co-authored-by: Vincent Smedinga <v.smedinga@amsterdam.nl>
github-actions
bot
temporarily deployed
to
demo-DES-1024-pagination-links-instead-of-buttons
Co-authored-by: Vincent Smedinga <v.smedinga@amsterdam.nl>
github-actions
bot
temporarily deployed
to
demo-DES-1024-pagination-links-instead-of-buttons
…ttps://github.com/Amsterdam/design-system into feat/DES-1024-pagination-links-instead-of-buttons
github-actions
bot
temporarily deployed
to
demo-DES-1024-pagination-links-instead-of-buttons
Co-authored-by: Vincent Smedinga <v.smedinga@amsterdam.nl>
github-actions
bot
temporarily deployed
to
demo-DES-1024-pagination-links-instead-of-buttons
…ttps://github.com/Amsterdam/design-system into feat/DES-1024-pagination-links-instead-of-buttons
github-actions
bot
temporarily deployed
to
demo-DES-1024-pagination-links-instead-of-buttons
github-actions
bot
temporarily deployed
to
demo-DES-1024-pagination-links-instead-of-buttons
…into feat/DES-1024-pagination-links-instead-of-buttons
github-actions
bot
temporarily deployed
to
demo-DES-1024-pagination-links-instead-of-buttons
github-actions
bot
temporarily deployed
to
demo-DES-1024-pagination-links-instead-of-buttons
github-actions
bot
temporarily deployed
to
demo-DES-1024-pagination-links-instead-of-buttons
github-actions
bot
temporarily deployed
to
demo-DES-1024-pagination-links-instead-of-buttons
VincentSmedinga
approved these changes
Jan 24, 2025
VincentSmedinga
deleted the
feat/DES-1024-pagination-links-instead-of-buttons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
It makes Pagination use links instead of buttons.
Why
Links make more sense here. Pagination is a
navsection, which has to contain links.In our guidelines we mention that clicking a Pagination link should navigate to the top of a new page.
That is default link behaviour.
Using links also allows users to open pages in a new tab, which isn't possible with buttons.
How
Using
ainstead ofbutton, and getting rid of all the state stuff.Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary: