feat(Accordion, Alert, Dialog, Form Error List, Heading)!: Require explicit heading levels #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want people to consider which level fits best in each situation.
VincentSmedinga
force-pushed
the
feat/require-heading-level
branch
from
c5e18dd to
72cb92c
Compare
github-actions
bot
temporarily deployed
to
demo-require-heading-level
VincentSmedinga
commented
Jan 16, 2025
alimpens
reviewed
Jan 17, 2025
github-actions
bot
temporarily deployed
to
demo-require-heading-level
VincentSmedinga
changed the title
github-actions
bot
temporarily deployed
to
demo-require-heading-level
github-actions
bot
temporarily deployed
to
demo-require-heading-level
This reverts commit b5614f6.
github-actions
bot
temporarily deployed
to
demo-require-heading-level
github-actions
bot
temporarily deployed
to
demo-require-heading-level
alimpens
reviewed
Jan 22, 2025
Co-authored-by: Aram <37216945+alimpens@users.noreply.github.com>
github-actions
bot
temporarily deployed
to
demo-require-heading-level
alimpens
previously approved these changes
Jan 22, 2025
github-actions
bot
temporarily deployed
to
demo-require-heading-level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What
Requires providing a
levelfor Heading and aheadingLevelfor Accordion, Alert, Dialog, and Form Error List.Why
The heading level has no sensible default; it can appear anywhere in the document’s hierarchy. We need people to consider which level fits best in each situation.
How
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes
n/a