feat: Remove Beta status from Header and deprecate Mega Menu #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentSmedinga
commented
Jan 13, 2025
| @@ -20,4 +20,5 @@ const MegaMenuRoot = forwardRef( | |||
|
|
|||
| MegaMenuRoot.displayName = 'MegaMenu' | |||
|
|
|||
| /** @deprecated Use child components in Header instead. */ | |||
There was a problem hiding this comment.
We probably want this deprecation to appear in the change log. Where should we list it, under ‘Features’?
There was a problem hiding this comment.
Yes, I think so. It's a deprecation of a feature.
dlnr
approved these changes
Jan 13, 2025
alimpens
approved these changes
Jan 17, 2025
| @@ -20,4 +20,5 @@ const MegaMenuRoot = forwardRef( | |||
|
|
|||
| MegaMenuRoot.displayName = 'MegaMenu' | |||
|
|
|||
| /** @deprecated Use child components in Header instead. */ | |||
There was a problem hiding this comment.
Yes, I think so. It's a deprecation of a feature.
alimpens
changed the title
github-actions
bot
temporarily deployed
to
demo-update-header-and-mega-menu-statuses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Header component is no longer in Beta.
The Mega Menu component is deprecated. I’ve updated the Status Badge component to allow customizing the status label and making it red for a deprecation.