Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unnecessary overrides #1804

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

alimpens
Copy link
Contributor

@alimpens alimpens commented Jan 8, 2025

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

It removes pnpm overrides.

Why

They aren't necessary anymore. I removed them and ran pnpm audit, and no vulnerabilities were found.

How

Select and delete 😁

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

@alimpens alimpens changed the title [chore]: Remove unnecessary overrides chore: Remove unnecessary overrides Jan 8, 2025
@github-actions github-actions bot temporarily deployed to demo-remove-overrides January 8, 2025 09:06 Destroyed
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@VincentSmedinga VincentSmedinga merged commit 588fd51 into develop Jan 8, 2025
6 checks passed
@VincentSmedinga VincentSmedinga deleted the remove-overrides branch January 8, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants