Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'meaningful' checks to php #114

Conversation

convenient
Copy link
Contributor

@convenient convenient commented Nov 6, 2023

Part of #110

We do not look for "redundant" overrides as with class names etc it can be quite hard. We'll filter out comments/whitespace etc which should do a good job anyway. (This is inline with the issue as it was raised #85)

For ignoring non-meaningful changes these are split into two groups

  • Preferences/Plugins - Downgrade from WARN to IGNR if the change is identified as non-meaningful.
  • Setup/Schema/Etc - Do not even run the check, because they are INFO level anyway just ignore them and remove from the report entirely.

For example

| IGNR  | Preference               | vendor/ampersand/upgrade-patch-helper-test-module/src/module/Model/ToPreferenceAndIgnore.php                                       | Ampersand\Test\Model\ToPreferenceAndIgnore                                                                                         |

In this case vendor/ampersand/upgrade-patch-helper-test-module/src/module/Model/ToPreferenceAndIgnore.php had some whitespace/comment style change, and theres no need to report you have a preference of Ampersand\Test\Model\ToPreferenceAndIgnore defined.

@convenient convenient marked this pull request as ready for review November 7, 2023 11:59
@convenient convenient merged commit 470ba5e into poc-meaningful-semantic-understanding-of-file-changes Nov 7, 2023
@convenient convenient deleted the poc-meaningful-semantic-understanding-of-file-changes-php branch November 7, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant