Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support exploded syntax in sdk #2896

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sdo-1A
Copy link
Contributor

@sdo-1A sdo-1A commented Feb 24, 2025

Proposed change

Support of exploded syntax for query and path parameters: https://swagger.io/docs/specification/v3_0/serialization/
This is an alternate solution to the existing PR #2865 to avoid breaking changes.

Related issues

#640

- No issue associated -

Copy link

nx-cloud bot commented Feb 24, 2025

View your CI Pipeline Execution ↗ for commit d8fe62b.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 12m 52s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-24 17:42:21 UTC

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 81.57895% with 14 lines in your changes missing coverage. Please review.

Project coverage is 69.72%. Comparing base (d2e9a76) to head (d8fe62b).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ges/@ama-sdk/core/src/clients/api-beacon-client.ts 0.00% 6 Missing ⚠️
...ages/@ama-sdk/core/src/clients/api-fetch-client.ts 0.00% 6 Missing ⚠️
packages/@ama-sdk/core/src/fwk/api.helpers.ts 96.87% 2 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdo-1A sdo-1A marked this pull request as ready for review February 25, 2025 08:59
@sdo-1A sdo-1A requested a review from a team as a code owner February 25, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants