Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: figma plugin for palette local variables #2870

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: figma plugin for palette local variables #2870

wants to merge 1 commit into from

Conversation

vscaiceanu-1a
Copy link
Member

Proposed change

First version of the Figma plugin for storing palettes in local variables

@vscaiceanu-1a vscaiceanu-1a requested a review from a team as a code owner February 19, 2025 06:44
@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/figma-palette-plugin branch 2 times, most recently from 0bb818b to d1f8402 Compare February 19, 2025 06:53
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 19, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 32ffad9.

Command Status Duration Result
nx run-many --target=test-e2e ✅ Succeeded 7m 23s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded <1s View ↗
nx run-many --target=test-int ✅ Succeeded 2s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 30s View ↗
nx run-many --target=prepare-publish --exclude-... ✅ Succeeded 1m 21s View ↗
nx run-many --target=documentation ✅ Succeeded 1m 14s View ↗
nx affected --target=test --collectCoverage ✅ Succeeded 5s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded 4s View ↗
Additional runs (3) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-02-25 09:45:50 UTC

@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/figma-palette-plugin branch from d1f8402 to 0ffe36d Compare February 19, 2025 07:37
kpanot
kpanot reviewed Feb 19, 2025
View reviewed changes
apps/palette-generator/manifest.json
@@ -0,0 +1,18 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they provide a Json Schema?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find one.
There's an outdated one here https://github.com/figmatic-team/figma-plugin-manifest
and a request for one here https://forum.figma.com/suggest-a-feature-11/jsonschema-for-manifest-json-21692

@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/figma-palette-plugin branch 3 times, most recently from cac88b4 to a28da7d Compare February 19, 2025 08:24
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.61%. Comparing base (a026fc1) to head (32ffad9).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matthieu-crouzet
matthieu-crouzet reviewed Feb 19, 2025
View reviewed changes
@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/figma-palette-plugin branch 5 times, most recently from 611f047 to 46a42ef Compare February 19, 2025 14:07
@kpanot kpanot mentioned this pull request Feb 20, 2025
Open
10 tasks
@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/figma-palette-plugin branch 2 times, most recently from 939b4a6 to f5b4c8e Compare February 20, 2025 15:58
@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/figma-palette-plugin branch from f5b4c8e to e4c2dd2 Compare February 20, 2025 16:38
@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/figma-palette-plugin branch 2 times, most recently from 4ce1c07 to 1286de4 Compare February 20, 2025 16:55
fpaul-1A
fpaul-1A reviewed Feb 20, 2025
View reviewed changes
apps/palette-generator/src/ui/ui.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have e2e testing for that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. we can explore this in #2876

@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/figma-palette-plugin branch 2 times, most recently from 872119e to 0c98a61 Compare February 21, 2025 13:10
@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/figma-palette-plugin branch from 0c98a61 to 70ffd1c Compare February 24, 2025 08:54
@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/figma-palette-plugin branch 2 times, most recently from 9a90f64 to ccd6869 Compare February 24, 2025 15:09
@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/figma-palette-plugin branch from ccd6869 to 8a13e0c Compare February 24, 2025 16:59
@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/figma-palette-plugin branch from 8a13e0c to 32ffad9 Compare February 25, 2025 08:25
kpanot
kpanot reviewed Feb 25, 2025
View reviewed changes
apps/palette-generator/tsconfig.build.plugin.json
@@ -0,0 +1,19 @@
// IDE usage only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it only used by the IDE?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I'm transpiling the plugin part with esbuild and I don't need a tsconfig file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpanot kpanot kpanot left review comments

@matthieu-crouzet matthieu-crouzet matthieu-crouzet left review comments

@cpaulve-1A cpaulve-1A cpaulve-1A left review comments

@fpaul-1A fpaul-1A fpaul-1A approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request project:@ama-terasu/cli project:cascading-gh-action project:get-npm-tag-gh-action project:new-version-gh-action project:@o3r/core project:@o3r/palette-generator project:release-gh-action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vscaiceanu-1a @kpanot @matthieu-crouzet @fpaul-1A @cpaulve-1A