Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_signal_handler2 exits always #111

Closed
rednach opened this issue Aug 13, 2018 · 5 comments
Closed

set_signal_handler2 exits always #111

rednach opened this issue Aug 13, 2018 · 5 comments

Comments

@rednach
Copy link

rednach commented Aug 13, 2018

exit(12) at https://github.com/Alignak-monitoring-contrib/alignak-module-ws/blob/develop/alignak_module_ws/ws.py#L1837 kills the module, so modulesmanager is trying to restart it forever...

@mohierf
Copy link
Contributor

mohierf commented Aug 13, 2018

WTF ... sorry for this! I will fix rapidly !

@mohierf
Copy link
Contributor

mohierf commented Aug 13, 2018

Indeed, I added this function to make some tests about killing modules. This function is not, anyway, useful because it exists in the Alignak BaseModule class which is inherited by the module ... but it looks like if it is never called. The problem you found shows that it is called ! 😞

mohierf added a commit that referenced this issue Aug 13, 2018
@rednach
Copy link
Author

rednach commented Aug 13, 2018

I am an expert in this kind of ... errors. Thank you for your rapid response!

@mohierf
Copy link
Contributor

mohierf commented Aug 13, 2018

Indeed, I added this function to make some tests for Alignak killing the modules. This function is not, anyway, useful because it exists in the Alignak BaseModule class which is inherited by the module ... but it looks like if it is never called. The problem you found shows that it is called ! 😞

@mohierf
Copy link
Contributor

mohierf commented Aug 14, 2018

I removed the signals management from the module to use the fucntions of the base class. This modification arose a small problem with the unit tests and I also fixed this. Travis tests in progress...

mohierf added a commit that referenced this issue Aug 14, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fixes #111 - stupid error in the signals management...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants