New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narrow public API and clean up some implementation #1

Open

bowbahdoe wants to merge 8 commits into AlexEidt:master from bowbahdoe:master

bowbahdoe commented May 16, 2022 •

edited

Loading

Makes most classes final so as to reduce the public api surface of this as a library.
Utils only has static methods, so hid its constructor
Make SeamCarverBase non-public and abstract
Instead of using new Thread directly, use an ExecutorService
EnergyType is part of a public api but isn't a public class

bowbahdoe added 8 commits

May 16, 2022 07:08


          Make EnergyType public so you can use SeamCarverFactory

4210b55


          Make GUI final

f8c4d56


          Make Main final

846a173


          Make SeamCarver* final

66dc1f4


          Make SeamCarverFactory final

005e524


          Make utils final and unconstructable

1e0e641


          Use ExecutorService instead of creating threads manually

8b724ac


          Make SeamCarverBase non-public and abstract

7d0f301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet