Skip to content
This repository was archived by the owner on Mar 7, 2025. It is now read-only.

Bump dropdown version for bib issue solution #283

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Dec 6, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #282

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Enhancements:

  • Update dependencies to newer versions, including auro-dropdown, auro-input, auro-popover, and various devDependencies.

@jordanjones243 jordanjones243 self-assigned this Dec 6, 2024
@jordanjones243 jordanjones243 requested a review from a team as a code owner December 6, 2024 21:34
Copy link

sourcery-ai bot commented Dec 6, 2024

Reviewer's Guide by Sourcery

This PR updates several dependencies in the project, with a focus on upgrading the auro-dropdown component from version 3.1.3 to 3.2.1 to address issue #282. The changes primarily consist of version bumps for various dependencies in package.json and related version files.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated core Auro Design System components to newer versions
  • Upgraded auro-dropdown from 3.1.3 to 3.2.1
  • Upgraded auro-input from 4.0.0 to 4.3.0
  • Upgraded auro-popover from 4.1.0 to 4.1.1
package.json
src/dropdownVersion.js
src/inputVersion.js
src/popoverVersion.js
Updated development dependencies to their latest versions
  • Upgraded various linting tools including eslint and stylelint
  • Updated build tools including rollup, sass, and typescript
  • Upgraded testing and automation dependencies
package.json
package-lock.json
Modified demo build artifacts
  • Updated minified demo files to reflect dependency changes
demo/api.min.js
demo/index.min.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@jordanjones243 jordanjones243 linked an issue Dec 6, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Dec 6, 2024

Surge demo deployment failed! 😭

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jordanjones243 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR removes version export files (dropdownVersion.js, inputVersion.js, popoverVersion.js) without explanation. Please clarify if these exports were being used anywhere and provide rationale for their removal.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

rmenner
rmenner previously approved these changes Dec 6, 2024
@rmenner rmenner self-requested a review December 6, 2024 22:42
@rmenner rmenner dismissed their stale review December 6, 2024 22:43

Need to check one more thing

@jason-capsule42 jason-capsule42 merged commit bb27690 into main Dec 7, 2024
6 of 7 checks passed
@jason-capsule42 jason-capsule42 deleted the jjones/bumpDropdown/#282 branch December 7, 2024 23:46
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump version of dropdown to fix popperjs issues
4 participants