Updates hex color label to entry, adds rgb entry option and cleans up the code a bit and adds docstrings to the functions along with comments. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… option to add rgb entries (only tested with horizontal layout))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needeed this kind of widget for a personal open source project but it missed a few features I was looking for, so I figured out I should add them.
Now the hex color is an editable entry, there is an option to add rgb entries to the widget and the target automatically updates its position (still in beta, cannot find all colors accurately).
(Editing the hex color entry automatically updates the rgb entries and viceversa).
Cleaned up the code a bit and added comments and docstrings to the functions.
For now I've edited ctk_color_picker_widget file because it is the one I needed to my project.