fix: remove save_resume/preserve_performance_counters options as it b…

…reaks SGD/BFGS chaining (microsoft#828)
AhnLab-OSS · Mar 24, 2020 · 842ccd0 · 842ccd0
1 parent d58401f
commit 842ccd0
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/main/scala/com/microsoft/ml/spark/vw/VowpalWabbitBase.scala b/src/main/scala/com/microsoft/ml/spark/vw/VowpalWabbitBase.scala
@@ -393,7 +393,7 @@ trait VowpalWabbitBase extends Wrappable
 
     // add exposed parameters to the final command line args
     val vwArgs = new StringBuilder()
-      .append(s"${getArgs} --save_resume --preserve_performance_counters ")
+      .append(getArgs)
       .appendParamIfNotThere("hash_seed", "hash_seed", hashSeed)
       .appendParamIfNotThere("b", "bit_precision", numBits)
       .appendParamIfNotThere("l", "learning_rate", learningRate)

diff --git a/src/test/scala/com/microsoft/ml/spark/vw/VerifyVowpalWabbitRegressor.scala b/src/test/scala/com/microsoft/ml/spark/vw/VerifyVowpalWabbitRegressor.scala
@@ -131,4 +131,21 @@ class VerifyVowpalWabbitRegressor extends Benchmarks {
 
     assert (metric < 11)
   }
+
+  test("Verify SGD followed-by BFGS") {
+    val dataset = session.read.format("libsvm")
+      .load(DatasetUtils.regressionTrainFile("triazines.scale.reg.train.svmlight").toString)
+      .coalesce(1)
+
+    val model1 = new VowpalWabbitRegressor()
+      .setNumPasses(20)
+      .setArgs("--holdout_off --loss_function quantile -q :: -l 0.1")
+      .fit(dataset)
+
+    val model2 = new VowpalWabbitRegressor()
+      .setNumPasses(20)
+      .setArgs("--holdout_off --loss_function quantile -q :: -l 0.1 --bfgs")
+      .setInitialModel(model1.getModel)
+      .fit(dataset)
+  }
 }