Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/2061 print error if mcdev validationsjs could not be loaded due to a syntax error #2063

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Feb 7, 2025

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 7.7.0 milestone Feb 7, 2025
@JoernBerkefeld JoernBerkefeld self-assigned this Feb 7, 2025
@github-actions github-actions bot added the bug Something isn't working label Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

Coverage Report

Commit:1af7649
Base: develop@2c34c03

Type Base This PR
Total Statements Coverage  70.79%  70.77%  (-0.02%)
Total Branches Coverage  70.13%  70.05%  (-0.08%)
Total Functions Coverage  83.75%  83.75%  (+0%)
Total Lines Coverage  70.79%  70.77%  (-0.02%)
Details (changed files):
File Statements Branches Functions Lines
lib/Builder.js  85.67%  53.19%  100%  85.67%
lib/util/validations.js  78.68%  68.18%  100%  78.68%

@JoernBerkefeld JoernBerkefeld merged commit ef30819 into develop Feb 7, 2025
11 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/2061-print-error-if-mcdev-validationsjs-could-not-be-loaded-due-to-a-syntax-error branch February 7, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working validationRule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] print error if .mcdev-validations.js could not be loaded due to a syntax error
1 participant