Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/1248 max line width breaks ampscript code in assets + require node >=18.18.2 + bump beauty-amp-core2 to 0.4.9 #1341

Merged
merged 10 commits into from
May 22, 2024
Merged

Bug/1248 max line width breaks ampscript code in assets + require node >=18.18.2 + bump beauty-amp-core2 to 0.4.9 #1341

merged 10 commits into from
May 22, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented May 22, 2024 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added the c/asset COMPONENT label May 22, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.0.0 milestone May 22, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this May 22, 2024
@github-actions github-actions bot added the bug Something isn't working label May 22, 2024
@JoernBerkefeld JoernBerkefeld changed the title Bug/1248 max line width breaks ampscript code in assets Bug/1248 max line width breaks ampscript code in assets + require node >=18.18.2 May 22, 2024
@JoernBerkefeld JoernBerkefeld changed the title Bug/1248 max line width breaks ampscript code in assets + require node >=18.18.2 Bug/1248 max line width breaks ampscript code in assets + require node >=18.18.2 + bump beauty-amp-core2 to 0.4.9 May 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

Coverage Report

Commit:e2876a2
Base: develop@9ab6876

Type Base This PR
Total Statements Coverage  67.86%  67.86%  (+0%)
Total Branches Coverage  67.06%  67.08%  (+0.02%)
Total Functions Coverage  79.18%  79.18%  (+0%)
Total Lines Coverage  67.86%  67.86%  (+0%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/Asset.js  64.3%  56.56%  82.5%  64.3%

@JoernBerkefeld JoernBerkefeld merged commit 49382d6 into develop May 22, 2024
5 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/1248-max-line-width-breaks-ampscript-code-in-assets branch May 22, 2024 10:02
@JoernBerkefeld JoernBerkefeld linked an issue May 22, 2024 that may be closed by this pull request
[BUG] max line width breaks ampscript code in assets #1248
Closed
2 tasks
@github-actions github-actions bot mentioned this pull request May 22, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/asset COMPONENT
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

[BUG] max line width breaks ampscript code in assets
1 participant
@JoernBerkefeld