Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING Task/58 rewrite dependency variables to r format csclsroz 329 #1333

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented May 17, 2024

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 6.1.0 milestone May 17, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this May 17, 2024
@JoernBerkefeld JoernBerkefeld linked an issue May 17, 2024 that may be closed by this pull request
@github-actions github-actions bot added the chore Jira issue-type "Task" label May 17, 2024
Copy link

github-actions bot commented May 17, 2024

Coverage Report

Commit:0b51d56
Base: develop@81ba6af

Type Base This PR
Total Statements Coverage  67.98%  67.86%  (-0.12%)
Total Branches Coverage  67.1%  67.1%  (+0%)
Total Functions Coverage  79.18%  79.18%  (+0%)
Total Lines Coverage  67.98%  67.86%  (-0.12%)
Details (changed files):
File Statements Branches Functions Lines
lib/cli.js  0%  0%  0%  0%
lib/metadataTypes/Asset.js  64.3%  56.93%  82.5%  64.3%
lib/metadataTypes/AttributeGroup.js  88.52%  70%  100%  88.52%
lib/metadataTypes/AttributeSet.js  83.91%  73.07%  100%  83.91%
lib/metadataTypes/Automation.js  78.68%  62.14%  94.44%  78.68%
lib/metadataTypes/DataExtension.js  81.07%  69.61%  94.28%  81.07%
lib/metadataTypes/EmailSend.js  71.53%  35.71%  100%  71.53%
lib/metadataTypes/Event.js  49.21%  60%  22.22%  49.21%
lib/metadataTypes/ImportFile.js  72.13%  57.5%  100%  72.13%
lib/metadataTypes/Journey.js  57.34%  55.42%  83.33%  57.34%
lib/metadataTypes/MobileMessage.js  88.03%  72.09%  100%  88.03%
lib/metadataTypes/Query.js  94.22%  82.22%  100%  94.22%
lib/metadataTypes/SendClassification.js  92.3%  70%  100%  92.3%
lib/metadataTypes/TransactionalEmail.js  87.35%  70.58%  100%  87.35%
lib/metadataTypes/TransactionalPush.js  87.09%  57.14%  100%  87.09%
lib/metadataTypes/TransactionalSMS.js  83.56%  69.56%  81.81%  83.56%
lib/metadataTypes/TriggeredSend.js  51.8%  38.09%  60%  51.8%
lib/metadataTypes/Verification.js  91.12%  76.19%  88.88%  91.12%

@JoernBerkefeld JoernBerkefeld added c/asset COMPONENT c/attributeGroup COMPONENT c/automation COMPONENT c/emailSend COMPONENT c/journey COMPONENT c/query COMPONENT labels May 18, 2024
@JoernBerkefeld JoernBerkefeld force-pushed the task/58-rewrite-dependency-variables-to-r__-format-csclsroz-329 branch from 7283a9d to d64eb47 Compare May 21, 2024 11:45
@JoernBerkefeld JoernBerkefeld force-pushed the task/58-rewrite-dependency-variables-to-r__-format-csclsroz-329 branch from d64eb47 to 94e1cb1 Compare May 21, 2024 12:16
@JoernBerkefeld JoernBerkefeld changed the title Task/58 rewrite dependency variables to r format csclsroz 329 BREAKING Task/58 rewrite dependency variables to r format csclsroz 329 May 21, 2024
@JoernBerkefeld JoernBerkefeld merged commit a0b49b4 into develop May 21, 2024
8 checks passed
@JoernBerkefeld JoernBerkefeld deleted the task/58-rewrite-dependency-variables-to-r__-format-csclsroz-329 branch May 21, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Rewrite dependency variables to r__ format / CSCLSROZ-329
1 participant