Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/1246 enable enhanced typescript validation #1257

Merged

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Apr 11, 2024

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld self-assigned this Apr 11, 2024
@JoernBerkefeld JoernBerkefeld added this to the 6.1.0 milestone Apr 11, 2024
@github-actions github-actions bot added the chore Jira issue-type "Task" label Apr 11, 2024
Copy link

github-actions bot commented Apr 11, 2024

Coverage Report

Commit:d688cb4
Base: develop@10323a0

Type Base This PR
Total Statements Coverage  65.69%  65.61%  (-0.08%)
Total Branches Coverage  66.54%  66.71%  (+0.17%)
Total Functions Coverage  74.61%  74.83%  (+0.22%)
Total Lines Coverage  65.69%  65.61%  (-0.08%)
Details (changed files):
File Statements Branches Functions Lines
lib/Builder.js  73.1%  50%  83.33%  73.1%
lib/Deployer.js  82.06%  68.75%  100%  82.06%
lib/MetadataTypeDefinitions.js  100%  100%  100%  100%
lib/Retriever.js  82.25%  71.42%  100%  82.25%
lib/cli.js  0%  0%  0%  0%
lib/index.js  68.29%  52.94%  65.62%  68.29%
lib/retrieveChangelog.js  0%  0%  0%  0%
lib/metadataTypes/Asset.js  44.69%  56.73%  45.71%  44.69%
lib/metadataTypes/AttributeGroup.js  88.42%  70%  100%  88.42%
lib/metadataTypes/AttributeSet.js  83.95%  73.07%  100%  83.95%
lib/metadataTypes/Automation.js  80.3%  63.2%  94.44%  80.3%
lib/metadataTypes/Campaign.js  66.29%  100%  33.33%  66.29%
lib/metadataTypes/ContentArea.js  50.92%  100%  0%  50.92%
lib/metadataTypes/DataExtension.js  79.21%  66.02%  94.28%  79.21%
lib/metadataTypes/DataExtensionField.js  80.84%  66.66%  90%  80.84%
lib/metadataTypes/DataExtensionTemplate.js  84.9%  66.66%  100%  84.9%
lib/metadataTypes/DataExtract.js  91.04%  54.54%  100%  91.04%
lib/metadataTypes/DataExtractType.js  96.15%  100%  50%  96.15%
lib/metadataTypes/Discovery.js  63.07%  100%  0%  63.07%
lib/metadataTypes/Email.js  66.66%  66.66%  33.33%  66.66%
lib/metadataTypes/EmailSend.js  30.9%  66.66%  16.66%  30.9%
lib/metadataTypes/Event.js  51.94%  100%  10%  51.94%
lib/metadataTypes/FileLocation.js  96.15%  100%  50%  96.15%
lib/metadataTypes/FileTransfer.js  89.37%  52.17%  100%  89.37%
lib/metadataTypes/Filter.js  95.55%  100%  0%  95.55%
lib/metadataTypes/Folder.js  57.75%  64.61%  80%  57.75%
lib/metadataTypes/ImportFile.js  71.3%  57.5%  100%  71.3%
lib/metadataTypes/Journey.js  54.27%  47.88%  100%  54.27%
lib/metadataTypes/List.js  91.03%  64.28%  66.66%  91.03%
lib/metadataTypes/MetadataType.js  78.31%  74.08%  71.01%  78.31%
lib/metadataTypes/MobileCode.js  87.71%  100%  50%  87.71%
lib/metadataTypes/MobileKeyword.js  89.31%  78.57%  90.9%  89.31%
lib/metadataTypes/MobileMessage.js  88.3%  72.09%  100%  88.3%
lib/metadataTypes/Query.js  93.13%  79.54%  100%  93.13%
lib/metadataTypes/Role.js  42.1%  55.55%  16.66%  42.1%
lib/metadataTypes/Script.js  95.65%  73.68%  100%  95.65%
lib/metadataTypes/SendClassification.js  75.47%  100%  0%  75.47%
lib/metadataTypes/SenderProfile.js  80.7%  60%  100%  80.7%
lib/metadataTypes/TransactionalEmail.js  87.4%  70.58%  100%  87.4%
lib/metadataTypes/TransactionalMessage.js  94.07%  86.66%  83.33%  94.07%
lib/metadataTypes/TransactionalPush.js  86.66%  57.14%  100%  86.66%
lib/metadataTypes/TransactionalSMS.js  85.25%  72.72%  81.81%  85.25%
lib/metadataTypes/TriggeredSend.js  41.54%  44.44%  60%  41.54%
lib/metadataTypes/User.js  86.2%  71.11%  95.83%  86.2%
lib/metadataTypes/Verification.js  91.12%  76.19%  88.88%  91.12%
lib/util/auth.js  65.4%  76.47%  66.66%  65.4%
lib/util/businessUnit.js  32.8%  100%  0%  32.8%
lib/util/cache.js  87.15%  65.51%  88.88%  87.15%
lib/util/cli.js  38.76%  76.92%  25%  38.76%
lib/util/config.js  54.15%  36.84%  100%  54.15%
lib/util/devops.js  14.62%  100%  25%  14.62%
lib/util/file.js  75.5%  57.57%  82.35%  75.5%
lib/util/init.config.js  19.95%  100%  0%  19.95%
lib/util/init.git.js  19.77%  100%  0%  19.77%
lib/util/init.js  18.82%  100%  0%  18.82%
lib/util/util.js  80.38%  77.69%  84.84%  80.38%

@JoernBerkefeld JoernBerkefeld linked an issue Apr 12, 2024 that may be closed by this pull request
@JoernBerkefeld JoernBerkefeld merged commit 8bb6c2b into develop Apr 12, 2024
4 checks passed
@JoernBerkefeld JoernBerkefeld deleted the task/1246-enable-enhanced-typescript-validation branch April 12, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Jira issue-type "Task"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] enable enhanced typescript validation
1 participant