Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1238: add more info to resolveId #1252

Merged

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Apr 9, 2024

PR details

What changes did you make? (Give an overview)

Further details (optional)

add { folder:string, isShared:boolean } and ContentBlockByName snippet to resolveId response

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 6.1.0 milestone Apr 9, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Apr 9, 2024
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

Coverage Report

Commit:6ad8334
Base: develop@8bb6c2b

Type Base This PR
Total Statements Coverage  65.61%  65.63%  (+0.02%)
Total Branches Coverage  66.65%  66.43%  (-0.22%)
Total Functions Coverage  74.83%  74.91%  (+0.08%)
Total Lines Coverage  65.61%  65.63%  (+0.02%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/Asset.js  46.19%  53.09%  48.64%  46.19%

Base automatically changed from task/1246-enable-enhanced-typescript-validation to develop April 12, 2024 20:04
…-block-id

# Conflicts:
#	lib/metadataTypes/Asset.js
@JoernBerkefeld JoernBerkefeld merged commit 1302d18 into develop Apr 14, 2024
7 checks passed
@JoernBerkefeld JoernBerkefeld deleted the feature/1238-get-name-and-key-for-content-block-id branch April 14, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant