Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] block cloudpages / asset-asset-webpage from getting created #2067

Closed
2 tasks done
JoernBerkefeld opened this issue Feb 10, 2025 · 1 comment · Fixed by #2068 or #2066
Closed
2 tasks done

[Feature] block cloudpages / asset-asset-webpage from getting created #2067

JoernBerkefeld opened this issue Feb 10, 2025 · 1 comment · Fixed by #2068 or #2066
Assignees
@JoernBerkefeld
Labels
c/asset COMPONENT e/DevOps EPIC enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" PRIORITY used for professional service clients
Milestone
7.7.0

Comments

@JoernBerkefeld
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

technically you can deploy the source code of a cloudpage but that only makes sense it is pre-existing. otherwise, you create a new asset that is not connected to an actual cloudpage and has no other purpose.

this could happen when trying to change the key (the wrong way) or simply by deploying changes upwords to the next environment based on createDeltaPkg

Expected Behavior

when attempting to CREATE an asset of subtype asset-asset, check if its property assetType.name === 'webpage' and then throw an ERROR and consequently skip the component.

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Run '...'
  4. See error...

Version

7.6.3

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added bug Something isn't working c/asset COMPONENT labels Feb 10, 2025
@JoernBerkefeld JoernBerkefeld added this to the 7.7.0 milestone Feb 10, 2025
@JoernBerkefeld JoernBerkefeld self-assigned this Feb 10, 2025
@JoernBerkefeld JoernBerkefeld added e/DevOps EPIC PRIORITY used for professional service clients labels Feb 10, 2025
JoernBerkefeld added a commit that referenced this issue Feb 10, 2025
@JoernBerkefeld
#2067: prevent cloudpage assets (asset-asset with assetType.name == '…
7e73e83 
…webpage') from being created via mcdev
@JoernBerkefeld JoernBerkefeld mentioned this issue Feb 10, 2025
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Feb 10, 2025 that will close this issue
feature/2067 prevent cloudpage assets (asset-asset with assetType.name == 'webpage') from being created via mcdev #2068
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld changed the title [BUG] block cloudpages / asset-asset-webpage from getting created [TASK] block cloudpages / asset-asset-webpage from getting created Feb 10, 2025
@JoernBerkefeld JoernBerkefeld added chore Jira issue-type "Task" enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" and removed bug Something isn't working chore Jira issue-type "Task" labels Feb 10, 2025
@JoernBerkefeld JoernBerkefeld changed the title [TASK] block cloudpages / asset-asset-webpage from getting created [Feature] block cloudpages / asset-asset-webpage from getting created Feb 10, 2025
@github-actions GitHub Actions
Copy link

Closed by #2068.

@JoernBerkefeld JoernBerkefeld mentioned this issue Feb 13, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/asset COMPONENT e/DevOps EPIC enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" PRIORITY used for professional service clients
Projects
None yet
Milestone
7.7.0
1 participant
@JoernBerkefeld