Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] default retrieve list includes empty string after mcdev upgrade #1360

Closed
2 tasks done
JoernBerkefeld opened this issue Jun 7, 2024 · 2 comments · Fixed by #1380 or #1381
Closed
2 tasks done

[BUG] default retrieve list includes empty string after mcdev upgrade #1360

JoernBerkefeld opened this issue Jun 7, 2024 · 2 comments · Fixed by #1380 or #1381
Assignees
@JoernBerkefeld
Labels
bug Something isn't working PRIORITY used for professional service clients
Milestone
7.0.1

Comments

@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented Jun 7, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

image

Caused by:

Expected Behavior

this is likely caused by the transactionalMessage shell class and should be filtered.
We should add tests for

  • mcdev upgrade (incl check of resulting config)
  • mcdev retrieve *

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Run '...'
  4. See error...

Version

7.0.0

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added bug Something isn't working PRIORITY used for professional service clients labels Jun 7, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.1.0 milestone Jun 7, 2024
@JoernBerkefeld
Copy link
Contributor Author

@DougMidgley - any chance you could look into this one? Im off and this seems to be a rather big one :(

@JoernBerkefeld JoernBerkefeld modified the milestones: 7.1.0, 7.0.1 Jun 11, 2024
JoernBerkefeld added a commit that referenced this issue Jun 22, 2024
@JoernBerkefeld
#1360: fix mcdev upgrade adding empty strings to auto-retrieve-list
78c42d4
JoernBerkefeld added a commit that referenced this issue Jun 22, 2024
@JoernBerkefeld
#1360: ensure explainTypes skips wrapper classes
5f61c7a
JoernBerkefeld added a commit that referenced this issue Jun 22, 2024
@JoernBerkefeld
#1360: ensure selectTypes skips wrapper classes
33e947e
@JoernBerkefeld JoernBerkefeld mentioned this issue Jun 22, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Jun 22, 2024 that will close this issue
Bug/1360 default retrieve list includes empty string after mcdev upgrade #1380
Merged
4 tasks
@github-actions GitHub Actions
Copy link

Closed by #1380.

@JoernBerkefeld JoernBerkefeld mentioned this issue Jun 22, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working PRIORITY used for professional service clients
Projects
None yet
Milestone
7.0.1
2 participants
@JoernBerkefeld @DougMidgley