Adapt to coq/coq#16743 (fix incomplete checking of unsolved holes) #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternatively we could define `exploit` as a Tactic Notation taking open_constr or uconstr (the problem is that arguments to a non-notation Ltac get interpreted as constr which doesn't allow holes, but in this case a hole gets solved by typeclass inference leaving a new hole behing, and due to the bug the new hole isn't detected).
|
I'm fine with this change, even though I don't understand a word of the explanations :-) Why is this submitted as a draft PR ? |
|
Reflex from the usual way we do this |
|
Please merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatively we could define
exploitas a Tactic Notation takingopen_constr or uconstr (the problem is that arguments to a
non-notation Ltac get interpreted as constr which doesn't allow holes,
but in this case a hole gets solved by typeclass inference leaving a
new hole behing, and due to the bug the new hole isn't detected).