Improved compatibility with Coq 8.14 #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierleroy
force-pushed
the
coq-8.14-compat
branch
from
75139d8 to
a303446
Compare
This avoids a new warning of Coq 8.14.
Warning "deprecated hint rewrite without locality" cannot be addressed: the suggested fix (qualify with Global or Local or [#export]) is not supported by Coq 8.11 to 8.13 ! Warning "deprecated instance without locality" is turned off for generated file cparser/Parser.v only. Menhir needs to be changed so as to generate the `Global` modifier that would silence this warning.
xavierleroy
force-pushed
the
coq-8.14-compat
branch
from
aced79a to
af2b004
Compare
|
Coq 8.14.0 is about to be released, so it's time to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As usual, version 8.14 of Coq introduces new warnings, some of which cannot be honored without breaking backward compatibility with 8.13 and earlier. (Grmph.)
This PR is a best effort: address the warnings that can be addressed, and silence the others.
Backward compatibility was successfully tested with Coq 8.13, 8.11, and 8.9.