Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check extensions list on Apply #14858

Conversation

light-and-ray
Copy link
Contributor

@light-and-ray light-and-ray commented Feb 7, 2024

Description

There is creepy bug: when extension list is stacked (endless "Loading..." and user presses "Apply and restart UI", ui enables every extension, and with high probability ui cannot start because of few extension. And you need to run webui in disabled extensions mode, and check which extensions you want to use again

Checklist:

@w-e-w
Copy link
Collaborator

w-e-w commented Feb 8, 2024

oh nice, if I'm reading this correctly you solved an issue that I've been trying to squash for a while

sometimes seemingly at random especially when I'm testing extensions like launching and relaunching multiple times rapidly
webui would seemingly at random decides to enable all extensions
since I test lots of extensions and I have 95% of them disabled, enabling all them basically means all hell break loose

@light-and-ray
Copy link
Contributor Author

Idk, maybe. About 1-2 month ago I accidentally pressed it, and had a lot of troubles. I remembered about it yesterday because I decided to make refresh button, because stacking of the table loading is annoying me

@AUTOMATIC1111
Copy link
Owner

It's good that you found it but there's got to be a better solution... What if an extension has "Loading..." in its description?

@light-and-ray
Copy link
Contributor Author

light-and-ray commented Feb 9, 2024

Yes I can use == But I think it's very unlikely that somebody will use Loading... in extension name, but some themes can decorate this HTML element. Maybe

@w-e-w
Copy link
Collaborator

w-e-w commented Feb 9, 2024

let me have a go

@light-and-ray
Copy link
Contributor Author

Yeah, looks better 👍🏻

@AUTOMATIC1111
Copy link
Owner

Merged in the other one.

@light-and-ray light-and-ray deleted the check_extensions_list_on_apply branch February 11, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants