Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sd-webui-video-extras-tab #266

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

light-and-ray
Copy link
Contributor

@light-and-ray light-and-ray commented Jan 15, 2024

Info

https://github.com/light-and-ray/sd-webui-video-extras-tab
This extension is needed to process video frame by frame inside extras tab.

Checklist:

  • I have read the Readme.md
  • The description is written in English.
  • The index.json and extension_template.json have not been modified.
  • The entry is placed in the extensions directory with the .json file extension.

@light-and-ray
Copy link
Contributor Author

light-and-ray commented Jan 15, 2024

Important thing I understood while developing the extension is
shared.state.assign_current_image(image_data)
And later:
image_data.close()
Inside postprocessing.py is a reason of random crashes in extras tab. I broke my whole head, before i tested it with regular big batch from dir. )) It should be fixed. Maybe I will make a PR inside webui later. And also it's better to use output images as preview, it can solve two problems by one time.

@light-and-ray
Copy link
Contributor Author

@w-e-w
Copy link
Collaborator

w-e-w commented Jan 19, 2024

I was just reading that PR moments ago

tip youi can write your commsnts like this

- https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/14699

and it will look like this

@w-e-w
Copy link
Collaborator

w-e-w commented Jan 23, 2024

some issues doesn't prevent it from you you're working, I fixed some of it

@w-e-w w-e-w merged commit 1d05b5e into AUTOMATIC1111:extensions Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants