Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mbed device-management command for Python 3.8 #14038

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Fix mbed device-management command for Python 3.8 #14038

merged 1 commit into from
Dec 17, 2020

Conversation

fkjagodzinski
Copy link
Member

Summary of changes

Bump the future module version to 0.18.0 to fix an ImportError present for Python 3.8:

ImportError: cannot import name 'splitattr' from 'urllib.request' (/usr/lib/python3.8/urllib/request.py)

The upstream issue for the future module -- PythonCharmers/python-future#447. Fixed in v0.18.0.
Fixes #14037.

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170

@fkjagodzinski
Fix mbed device-management command for Python 3.8
85bc040 
Bump the `future` module version to 0.18.0 to fix an ImportError present
for Python 3.8:

ImportError: cannot import name 'splitattr' from 'urllib.request' (/usr/lib/python3.8/urllib/request.py)
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Dec 11, 2020
@ciarmcom
Copy link
Member

@fkjagodzinski, thank you for your changes.
@0xc0170 @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from 0xc0170 and a team December 11, 2020 23:00
@mergify mergify bot added needs: CI and removed needs: review labels Dec 14, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 14, 2020

CI started

@teetak01
Copy link
Contributor

@0xc0170 @artokin this probably should be cherry-picked to mbed-os-5.15 and feature-wisun also.

@mbed-ci
Copy link

mbed-ci commented Dec 14, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

This was referenced Dec 16, 2020
Merged
Merged
@0xc0170 0xc0170 merged commit 4ad6f5d into ARMmbed:master Dec 17, 2020
@mergify mergify bot removed the ready for merge label Dec 17, 2020
@fkjagodzinski fkjagodzinski deleted the fix-mbed_dm_command_with_py3.8 branch December 17, 2020 11:56
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The mbed device-management command fails with Python 3.8
6 participants
@fkjagodzinski @ciarmcom @0xc0170 @teetak01 @mbed-ci @mbedmain