Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Use recent Ubuntu in test_matlab.yml #2653

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 4, 2025

Ubuntu 20.04 is no longer supported.

dweindl added 2 commits March 4, 2025 16:02
Ubuntu 20.04 is no longer supported.
@dweindl
Copy link
Member Author

dweindl commented Mar 4, 2025

24.04:

  {Invalid MEX-file
  '/home/runner/work/AMICI/AMICI/models/model_calvetti/ami_model_calvetti.mexa64':
  /opt/hostedtoolcache/MATLAB/2024.2.999/x64/bin/glnxa64/../../sys/os/glnxa64/libstdc++.so.6:
  version `GLIBCXX_3.4.32' not found (required by
  /home/runner/work/AMICI/AMICI/models/model_calvetti/ami_model_calvetti.mexa64)
  
  Error in simulate_model_calvetti (line 222)
  sol = ami_model_calvetti(tout,theta(1:0),kappa(1:6),options_ami,plist,xscale,init,data);
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  Error in testModels/getResults (line 83)
          sol = feval(['simulate_' modelname],t,theta,kappa,ami_data,ami_options);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  Error in testModels (line 57)
              sol = getResults(modelname,options,data,t,theta,kappa);
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  Error in command_41126276_c19a_449d_93a5_9c568aff00e6 (line 1)
  cd(getenv('MW_ORIG_WORKING_FOLDER'));cd matlab; installAMICI; addpath tests; testModels
                                                                               ^^^^^^^^^^
  }

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.16%. Comparing base (4764b67) to head (812dec2).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2653   +/-   ##
========================================
  Coverage    77.16%   77.16%           
========================================
  Files          332      332           
  Lines        23142    23142           
  Branches      1480     1480           
========================================
  Hits         17857    17857           
  Misses        5274     5274           
  Partials        11       11           
Flag Coverage Δ
cpp 74.09% <ø> (ø)
cpp_python 33.38% <ø> (ø)
petab 39.40% <ø> (ø)
python 72.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dweindl dweindl marked this pull request as ready for review March 4, 2025 15:58
@dweindl dweindl requested a review from a team as a code owner March 4, 2025 15:58
@dweindl dweindl enabled auto-merge March 4, 2025 15:58
@dweindl dweindl added this pull request to the merge queue Mar 4, 2025
Merged via the queue into AMICI-dev:develop with commit a6c6866 Mar 4, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants