simulate_petab: Avoid warning when simulating with default parameters #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a "unused parameters" warning when using simulate_petab with default parameters. By default, fixed parameters are hard-coded during parameter mapping, and thus, must not be passed to `fill_in_edatas` later on. This warning was swallowed until recently (AMICI-dev#2243).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2265 +/- ##
============================================
+ Coverage 48.30% 77.04% +28.74%
============================================
Files 92 92
Lines 14988 14987 -1
============================================
+ Hits 7240 11547 +4307
+ Misses 7748 3440 -4308
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Reviewed as part of #2255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a "unused parameters" warning when using simulate_petab with default parameters. By default, fixed parameters are hard-coded during parameter mapping, and thus, must not be passed to
fill_in_edataslater on. This warning was swallowed until recently (#2243).