Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swig shadow warning + other linting issues #2261

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 5, 2024

Fixes swig warning

include/amici/simulation_parameters.h:71: Warning 509: Overloaded method amici::SimulationParameters::SimulationParameters(std::vector< amici::realtype,std::allocator< amici::realtype > >,std::vector< amici::realtype,std::allocator< amici::realtype > >,std::vector< amici::realtype,std::allocator< amici::realtype > >) effectively ignored,
include/amici/simulation_parameters.h:54: Warning 509: as it is shadowed by amici::SimulationParameters::SimulationParameters(std::vector< amici::realtype,std::allocator< amici::realtype > >,std::vector< amici::realtype,std::allocator< amici::realtype > >,std::vector< int,std::allocator< int > >).

and some other linting warnings.

Fixes swig warning
```
include/amici/simulation_parameters.h:71: Warning 509: Overloaded method amici::SimulationParameters::SimulationParameters(std::vector< amici::realtype,std::allocator< amici::realtype > >,std::vector< amici::realtype,std::allocator< amici::realtype > >,std::vector< amici::realtype,std::allocator< amici::realtype > >) effectively ignored,
include/amici/simulation_parameters.h:54: Warning 509: as it is shadowed by amici::SimulationParameters::SimulationParameters(std::vector< amici::realtype,std::allocator< amici::realtype > >,std::vector< amici::realtype,std::allocator< amici::realtype > >,std::vector< int,std::allocator< int > >).
```

and some other linting warnings.
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a253b17) 76.46% compared to head (1aa2b8c) 76.54%.
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2261      +/-   ##
===========================================
+ Coverage    76.46%   76.54%   +0.08%     
===========================================
  Files           92       92              
  Lines        14975    14974       -1     
===========================================
+ Hits         11450    11462      +12     
+ Misses        3525     3512      -13     
Flag Coverage Δ
cpp 73.11% <100.00%> (-0.01%) ⬇️
cpp_python 37.09% <0.00%> (+<0.01%) ⬆️
petab 52.90% <ø> (ø)
python 78.13% <ø> (+0.23%) ⬆️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
include/amici/logging.h 100.00% <ø> (ø)
include/amici/model.h 61.11% <ø> (ø)
include/amici/simulation_parameters.h 66.66% <ø> (ø)
src/steadystateproblem.cpp 83.66% <100.00%> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

@dweindl dweindl self-assigned this Jan 5, 2024
@dweindl dweindl marked this pull request as ready for review January 5, 2024 15:09
@dweindl dweindl requested a review from a team as a code owner January 5, 2024 15:09
@dweindl dweindl merged commit 9886c69 into AMICI-dev:develop Jan 6, 2024
@dweindl dweindl deleted the dw_cleanup branch January 6, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants