Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWIG __repr__s for different templated vector classes #2009

Merged
merged 2 commits into from
Feb 22, 2023
Merged

SWIG __repr__s for different templated vector classes #2009

merged 2 commits into from
Feb 22, 2023

Conversation

FFroehlich
Copy link
Member

fixes #2007

@FFroehlich FFroehlich requested a review from a team as a code owner February 21, 2023 19:33
@codecov
Copy link

codecov bot commented Feb 21, 2023 •
edited
Loading

Codecov Report

Merging #2009 (e6b2ca5) into develop (bd37745) will increase coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2009      +/-   ##
===========================================
+ Coverage    75.99%   76.06%   +0.07%     
===========================================
  Files           76       76              
  Lines        12996    12996              
===========================================
+ Hits          9876     9886      +10     
+ Misses        3120     3110      -10
Flag Coverage Δ
cpp 73.20% <ø> (ø)
petab 60.05% <ø> (ø)
python 68.88% <ø> (+0.22%) ⬆️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...thon/sdist/amici/conserved_quantities_demartino.py 65.55% <0.00%> (+1.95%) ⬆️

dweindl
dweindl approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@FFroehlich FFroehlich merged commit 34057d1 into develop Feb 22, 2023
@FFroehlich FFroehlich deleted the swig_vector_repr branch February 22, 2023 08:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweindl dweindl dweindl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FFroehlich @dweindl