Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PytestReturnNotNoneWarning in test_conserved_quantities_demartino.py #1968

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Fix PytestReturnNotNoneWarning in test_conserved_quantities_demartino.py #1968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions python/tests/test_conserved_quantities_demartino.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,13 +190,13 @@ def test_fill_demartino2014(data_demartino2014):
assert not any(fields[len(ref_for_fields):])


@skip_on_valgrind
def test_compute_moiety_conservation_laws_demartino2014(
def compute_moiety_conservation_laws_demartino2014(
data_demartino2014, quiet=False
):
"""Invoke test case and benchmarking for De Martino's published results
"""Compute conserved quantities for De Martino's published results
for E. coli network"""
stoichiometric_list, row_names = data_demartino2014

num_species = 1668
num_reactions = 2381
assert len(stoichiometric_list) == num_species * num_reactions, \
Expand All @@ -216,6 +216,15 @@ def test_compute_moiety_conservation_laws_demartino2014(
return runtime


@skip_on_valgrind
def test_compute_moiety_conservation_laws_demartino2014(data_demartino2014):
"""Invoke test case and benchmarking for De Martino's published results
for E. coli network"""
compute_moiety_conservation_laws_demartino2014(
data_demartino2014, quiet=False
)


@skip_on_valgrind
@log_execution_time("Detecting moiety conservation laws", logger)
def test_cl_detect_execution_time(data_demartino2014):
Expand All @@ -229,7 +238,7 @@ def test_cl_detect_execution_time(data_demartino2014):
runtime = np.Inf

for _ in range(max_tries):
runtime = test_compute_moiety_conservation_laws_demartino2014(
runtime = compute_moiety_conservation_laws_demartino2014(
data_demartino2014, quiet=True)
if runtime < max_time_seconds:
break
Expand Down