Fix circular import in amici.petab_import_pysb #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`python -c "import amici.petab_import_pysb"` failed with something like `cannot import name 'PysbPetabProblem' from partially initialized module 'amici.petab_import_pysb' (most likely due to a circular import) (/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/amici/petab_import_pysb.py)`
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1922 +/- ##
===========================================
+ Coverage 75.98% 76.10% +0.11%
===========================================
Files 76 76
Lines 12965 12967 +2
===========================================
+ Hits 9852 9869 +17
+ Misses 3113 3098 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Kudos, SonarCloud Quality Gate passed!
|
FFroehlich
approved these changes
Dec 29, 2022
Depends on the import order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python -c "import amici.petab_import_pysb"failed with something likecannot import name 'PysbPetabProblem' from partially initialized module 'amici.petab_import_pysb' (most likely due to a circular import) (/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/amici/petab_import_pysb.py)