Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to convert ReturnData::status flags to string #1864

Merged
merged 3 commits into from
Sep 10, 2022
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Sep 10, 2022

No description provided.

@dweindl dweindl requested a review from FFroehlich September 10, 2022 08:41
@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Merging #1864 (d1d1733) into develop (906bc1f) will decrease coverage by 1.89%.
The diff coverage is 68.85%.

❗ Current head d1d1733 differs from pull request most recent head 39e4127. Consider uploading reports for the commit 39e4127 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1864      +/-   ##
===========================================
- Coverage    78.00%   76.10%   -1.90%     
===========================================
  Files           74       74              
  Lines        12116    12869     +753     
===========================================
+ Hits          9451     9794     +343     
- Misses        2665     3075     +410     
Flag Coverage Δ
cpp 72.79% <56.90%> (-2.23%) ⬇️
petab 58.92% <62.47%> (-0.77%) ⬇️
python 68.56% <61.32%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/amici/amici.h 100.00% <ø> (ø)
include/amici/edata.h 0.00% <ø> (ø)
include/amici/newton_solver.h 100.00% <ø> (ø)
include/amici/rdata.h 95.00% <ø> (+0.26%) ⬆️
include/amici/solver.h 83.33% <ø> (ø)
include/amici/steadystateproblem.h 100.00% <ø> (ø)
include/amici/sundials_linsol_wrapper.h 100.00% <ø> (ø)
include/amici/sundials_matrix_wrapper.h 89.23% <ø> (ø)
include/amici/vector.h 68.00% <0.00%> (-12.00%) ⬇️
python/amici/gradient_check.py 83.15% <0.00%> (-2.72%) ⬇️
... and 75 more

@dweindl dweindl merged commit 779624b into develop Sep 10, 2022
@dweindl dweindl deleted the status2str branch September 10, 2022 14:21
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants