Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding model name during PySB import #1801

Merged
merged 1 commit into from
May 20, 2022
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented May 20, 2022

No description provided.

@dweindl dweindl requested a review from FFroehlich May 20, 2022 11:17
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #1801 (e399958) into develop (8546384) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1801      +/-   ##
===========================================
+ Coverage    77.55%   77.57%   +0.01%     
===========================================
  Files           74       74              
  Lines        12346    12346              
===========================================
+ Hits          9575     9577       +2     
+ Misses        2771     2769       -2     
Flag Coverage Δ
cpp 74.27% <ø> (+0.02%) ⬆️
petab 60.77% <100.00%> (ø)
python 68.19% <25.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/petab_import.py 73.49% <100.00%> (-0.11%) ⬇️
python/amici/petab_import_pysb.py 92.45% <100.00%> (ø)
python/amici/pysb_import.py 94.56% <100.00%> (+0.01%) ⬆️
src/sundials_matrix_wrapper.cpp 81.41% <0.00%> (+0.41%) ⬆️

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 13b7422 into develop May 20, 2022
@dweindl dweindl deleted the pysb_model_name branch May 20, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants