Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI, python] Windows support #424

Closed
dweindl opened this issue Aug 31, 2018 · 9 comments
Closed

[CI, python] Windows support #424

dweindl opened this issue Aug 31, 2018 · 9 comments

Comments

@dweindl
Copy link
Member

dweindl commented Aug 31, 2018

Since we unfortunately decided to support Windows, it would be great if somebody could reenable/setup AppVeyor . This would also be helpful for the generation, and required for the auto-deployment of Windows wheels (#423).

@FFroehlich FFroehlich added this to the Python package usable on windows milestone Sep 6, 2018
@dweindl
Copy link
Member Author

dweindl commented Oct 12, 2018

@yannikschaelte : Wanna give it a try? :)

@FFroehlich
Copy link
Member

https://brew.sh/2019/02/02/homebrew-2.0.0/ this might simplify dependency installation on windows a bit.

@FFroehlich
Copy link
Member

Closing this due to lack of interest and https://docs.microsoft.com/en-us/windows/wsl/install-win10 as better alternative.

@dweindl
Copy link
Member Author

dweindl commented Sep 25, 2019

@thomassligon : Since you seem to be very interested in using AMICI with Visual C++, would you be able to set up a CI workflow for that? Otherwise, since none of the developers is using VC++, chances are high that future changes will break compatibility...

@thomassligon
Copy link
Contributor

That sounds reasonable, especially since the installation on Windows with Visual Studio seems to be almost working, as soon as a one-line fix becomes available, but first I need to understand what is expected. My guess is that "CI workflow" means "continuous integration workflow", but that is a very general concept and I don't know exactly what is expected. In particular, does this refer to a tool and managing the workflow in that tool? In addition, I don't know Appveyor, Windows wheels, or travis, so I might need to learn some of this, or, at least, know what a "CI workflow" needs to look like. PS: AMICI on Windows with Visual C++ was working for MATLAB, and using it with Python has uncovered one line of incompatible code, and there is already a fix for that, but it is not yet in master.

@dweindl
Copy link
Member Author

dweindl commented Sep 25, 2019

Hi Tom,

Our current continuous integration workflow, among others, builds AMICI and installs the Python package and then runs and verifies a number of test simulations. This currently happens on travis CI. See https://travis-ci.com/ICB-DCM/AMICI/jobs/232096602 for an example, and https://github.com/ICB-DCM/AMICI/blob/master/.travis.yml for how this is achieved.

There are different providers with free basic subscriptions and decent github integrations. At some point we used appveyor, see https://github.com/ICB-DCM/AMICI/blob/master/bu_.appveyor.yml for the broken configuration.

Options are:

I no Windows-experience with any of them and no clear preference.

The minimum we would need is:

  • Setting up the environment (python, VC++)
  • Performing the AMICI development installation

Ideally in addition:

  • Running the example Jupyter notebooks from python/examples/
  • Python-Windows-wheels deployment on tagged releases

We won't be able to test the matlab interface, due to licensing restrictions.

Regarding the pull request with fixes for your current issues: I commented on that earlier, should be merged soon. That was waiting due to me being on vacation.

@thomassligon
Copy link
Contributor

thomassligon commented Sep 25, 2019 via email

@dweindl
Copy link
Member Author

dweindl commented Sep 26, 2019

Also, I will look at the travis documentation you have cited, and maybe the others, with the goal of seeing how much work it would be to create the CI workflow that is needed.

Okay, great. Therefore reopening this issue.

@dweindl dweindl reopened this Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants