Speedup conservation law computation (#1754)

* speedup * Apply suggestions from code review Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com> Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
AMICI-dev · Apr 4, 2022 · 347a86d · 347a86d
1 parent da56a08
commit 347a86d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/python/amici/pysb_import.py b/python/amici/pysb_import.py
@@ -1015,12 +1015,12 @@ def _construct_conservation_from_prototypes(
         # x_j = (T - sum_i≠j(a_i * x_i))/a_j
         # law: sum_i≠j(a_i * x_i))/a_j
         # state: x_j
-        target_expression = sum(
+        target_expression = sp.Add(*(
             sp.Symbol(f'__s{ix}')
             * extract_monomers(specie).count(monomer_name)
             for ix, specie in enumerate(pysb_model.species)
             if ix != target_index
-        ) / extract_monomers(pysb_model.species[
+        )) / extract_monomers(pysb_model.species[
                                  target_index
                              ]).count(monomer_name)
         # normalize by the stoichiometry of the target species