Fix protocol, add test

AMICI-dev · Jan 16, 2023 · 09decac · 09decac
1 parent 24e22b8
commit 09decac
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/python/sdist/amici/__init__.py b/python/sdist/amici/__init__.py
@@ -120,13 +120,13 @@ def _imported_from_setup() -> bool:
     from .sbml_import import SbmlImporter, assignmentRules2observables
     from .ode_export import ODEModel, ODEExporter
 
-    from typing import Protocol
+    from typing import Protocol, runtime_checkable
 
 
+    @runtime_checkable
     class ModelModule(Protocol):
         """Enable Python static type checking for AMICI-generated model
         modules"""
-        module: "ModelModule"
 
         def getModel(self) -> amici.Model:
             ...

diff --git a/python/tests/test_sbml_import.py b/python/tests/test_sbml_import.py
@@ -180,6 +180,11 @@ def test_logging_works(observable_dependent_error_model, caplog):
     assert rdata.status != amici.AMICI_SUCCESS
     assert "mxstep steps taken" in caplog.text
 
+@skip_on_valgrind
+def test_model_module_is_set(observable_dependent_error_model):
+    model_module = observable_dependent_error_model
+    assert isinstance(model_module.getModel().module, amici.ModelModule)
+
 
 @pytest.fixture(scope='session')
 def model_steadystate_module():