Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/decoder #109

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Fix/decoder #109

merged 5 commits into from
Sep 27, 2024

Conversation

tsuzzy
Copy link
Collaborator

@tsuzzy tsuzzy commented Sep 19, 2024

Changes include:

  • Fixed the logic of reading .nmea/.txt file formats sent for processing.
  • Supported processing without tag blocks in AIS messages (NMEA).
  • Added example NMEA data and included its test case in test002.

Fixes issues #78, #85, and #93.

@tsuzzy
Copy link
Collaborator Author

tsuzzy commented Sep 19, 2024

Please keep #85 open and this branch alive, we may need to add a small feature for milliseconds timestamp reading. Thanks!

@gabrielspadon
Copy link
Collaborator

@tsuzzy Do you mean not to merge until you fix it?

@gabrielspadon gabrielspadon self-requested a review September 27, 2024 14:47
@gabrielspadon gabrielspadon merged commit cf1574c into master Sep 27, 2024
14 checks passed
@gabrielspadon gabrielspadon deleted the fix/decoder branch September 27, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielspadon gabrielspadon gabrielspadon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsuzzy @gabrielspadon