Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrap removal; Bump to v0.1.2 #3

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Unwrap removal; Bump to v0.1.2 #3

merged 5 commits into from
Feb 7, 2024

Conversation

BHouwens
Copy link
Contributor

@BHouwens BHouwens commented Feb 7, 2024

Description

Removes unsafe unwraps and panics from the code, preventing the Valence node from falling over due to bad data

Changelog

  • Updates the README with cargo info
  • Removes unsafe, process breaking code
  • Adds PR template

Type of Change

Please mark the appropriate option by putting an "x" inside the brackets:

  • Bug fix
  • New feature
  • Enhancement or optimization
  • Documentation update
  • Other (please specify)

Checklist

Put an "x" in the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • I have tested the changes locally and they work as expected.
  • I have added necessary documentation or updated existing documentation.
  • My code follows the project's coding standards and style guidelines.
  • I have added/updated relevant tests to ensure the changes are properly covered.
  • I have checked for and resolved any merge conflicts.
  • My commits have clear and descriptive messages.

@BHouwens BHouwens merged commit 69222aa into main Feb 7, 2024
1 check passed
@BHouwens BHouwens deleted the unwrap_removal branch May 23, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant