Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing DB entry structure #9

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Changing DB entry structure #9

merged 1 commit into from
Jun 26, 2024

Conversation

BHouwens
Copy link
Contributor

Description

Makes sweeping changes to the entries saved to DB and storage in general. Changes outlined below

Changelog

  • Changes entries per address to a HashMap instead of a Vec, where the map keys are IDs for each value of the address
  • Enable retrieval of specific address entries via unique ID (eg. /get_data/{id_value})
  • Fixes bug for returning serde_json::Value

Type of Change

Please mark the appropriate option by putting an "x" inside the brackets:

  • Bug fix
  • New feature
  • Enhancement or optimization
  • Documentation update
  • Other (please specify)

Checklist

Put an "x" in the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • I have tested the changes locally and they work as expected.
  • I have added necessary documentation or updated existing documentation.
  • My code follows the project's coding standards and style guidelines.
  • I have added/updated relevant tests to ensure the changes are properly covered.
  • I have checked for and resolved any merge conflicts.
  • My commits have clear and descriptive messages.

@BHouwens BHouwens requested a review from a team as a code owner June 26, 2024 11:16
@BHouwens BHouwens merged commit 2723c4f into develop Jun 26, 2024
1 check passed
@RobinP122 RobinP122 deleted the bugfix_json_value branch July 4, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant