Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix default handling #6

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Bugfix default handling #6

merged 5 commits into from
Jun 7, 2024

Conversation

BHouwens
Copy link
Contributor

@BHouwens BHouwens commented Jun 4, 2024

Description

Fixes the bug where a working cache produces a valid but null result, preventing the Valence node from defaulting to a database retrieval

Changelog

  • Defaults to database retrieval when the cache returns a null result

Type of Change

Please mark the appropriate option by putting an "x" inside the brackets:

  • Bug fix
  • New feature
  • Enhancement or optimization
  • Documentation update
  • Other (please specify)

Checklist

Put an "x" in the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • I have tested the changes locally and they work as expected.
  • I have added necessary documentation or updated existing documentation.
  • My code follows the project's coding standards and style guidelines.
  • I have added/updated relevant tests to ensure the changes are properly covered.
  • I have checked for and resolved any merge conflicts.
  • My commits have clear and descriptive messages.

@BHouwens BHouwens requested a review from a team as a code owner June 4, 2024 08:38
@BHouwens BHouwens requested a review from RobinP122 June 4, 2024 08:39
@RobinP122 RobinP122 merged commit 44b5347 into develop Jun 7, 2024
1 check passed
@RobinP122 RobinP122 deleted the bugfix_default_handling branch June 7, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants