Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sticky Card #371

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Add Sticky Card #371

merged 5 commits into from
Jan 16, 2024

Conversation

serenibyss
Copy link
Member

Adds the Sticky Card, similar to the EnderIO conduit upgrade.

If a storage bus or cell has a sticky card, items/fluids will only go to that location.

Example:

  • Storage bus filtered for Cobblestone with a sticky card, on a drawer
  • Try to insert cobblestone into the network, it will go to that drawer
  • Drawer is completely full, cobblestone will not be accepted into the net even if there is other space for it

Multiple locations partitioned with a sticky card will both accept the input still.

AE2FCR and NAE2 will need to update to add this upgrade to fluid cells/larger cells, but beyond that this is not a breaking change in any way

Copy link
Member

@NotMyWing NotMyWing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small issue I noticed is that cell stickiness was not propagated from drives, making them unavailable to the handler. Fixed in b5be4cc.

Awaiting cross-review.

@NotMyWing NotMyWing added the enhancement New feature or request label Jan 15, 2024
@NotMyWing
Copy link
Member

cc: @serenibyss

@NotMyWing NotMyWing merged commit a8f0bbe into master Jan 16, 2024
@NotMyWing NotMyWing deleted the sb-sticky-card branch January 16, 2024 01:27
AE2-Enthusiast pushed a commit to AE2-Enthusiast/AE2-UEL that referenced this pull request Apr 14, 2024
Co-authored-by: NotMyWing <winwyv@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants