Fix Level Emitter Buttons and fix ME IO Port not respecting it's redstone mode. #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title basically.
The Level Emitter's buttons were using the priority button's config for their values, seemingly because of a typo, so I fixed the typo.
And the IO Port could either be disabled by redstone or enabled by redstone, never pulsed or ignoring redstone. Since the IO Port has those as redstone modes as options, I assumed it's a bug and added code to the IO Port to allow pulsing and ignoring. This is will be my first time contributing to a real mod, so I don't know if my implementation is the most optimal. But, this change only affects the IO Port and I can't think of a better way, so it's probably fine.