doc: add break word all for better ux #753
Conversation
|
@rasvanjaya21 is attempting to deploy a commit to the 47ng Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -28,7 +28,7 @@ export function Demo() { | |||
| <> | |||
| <input value={name || ''} onChange={e => setName(e.target.value)} /> | |||
| <button onClick={() => setName(null)}>Clear</button> | |||
| <p>Hello, {name || 'anonymous visitor'}!</p> | |||
| <p className="break-all">Hello, {name || 'anonymous visitor'}!</p> | |||
There was a problem hiding this comment.
suggestion: styles are not needed in documentation code blocks, they distract from the main intent (showing how to use nuqs).
| <p className="break-all">Hello, {name || 'anonymous visitor'}!</p> | |
| <p>Hello, {name || 'anonymous visitor'}!</p> |
| @@ -24,7 +24,7 @@ export function Demo() { | |||
| onChange={e => setHello(e.target.value || null)} | |||
| data-interacted={Boolean(hello)} | |||
| /> | |||
| <p>Hello, {hello || 'anonymous visitor'}!</p> | |||
| <p className="break-all">Hello, {hello || 'anonymous visitor'}!</p> | |||
There was a problem hiding this comment.
suggestion: this file isn't used in the codebase, it was just a demo of how GitHub uses search params to store state, we should probably remove it.
| <p className="break-all">Hello, {hello || 'anonymous visitor'}!</p> | |
| <p>Hello, {hello || 'anonymous visitor'}!</p> |
| @@ -21,7 +21,7 @@ export async function LandingDemo() { | |||
| <div className="mb-4 h-[136px] animate-pulse rounded bg-zinc-50 dark:bg-zinc-900 sm:h-10" /> | |||
| } | |||
| > | |||
| <div className="mb-4 flex flex-col gap-4 sm:flex-row sm:items-center"> | |||
There was a problem hiding this comment.
Looks like this change broke the layout on mobile, the items should be full width:
|
🎉 This PR is included in version 2.3.2-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Implemented #752