Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform message edits on matrix #1286

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Conversation

nightmared
Copy link
Contributor

Hello,

as the title say, this adds a minimal support for message edition in the matrix bridge, trying to be compatible with https://github.com/Half-Shot/matrix-doc/blob/hs/1695-message-edits-proposal/proposals/1695-message-edits.md.

@42wim
Copy link
Owner

42wim commented Nov 7, 2020

Nice, thanks!
I'll try to test it tomorrow.

return json.Unmarshal(jsonObj, out)
}

func (b *Bmatrix) handleEdit(ev *matrix.Event, rmsg config.Message) (isEdit bool) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no named returns please

@42wim
Copy link
Owner

42wim commented Nov 8, 2020

Works great!
If you could fix this small nitpack, I can merge it.

@42wim 42wim added this to the 1.19.1 milestone Nov 8, 2020
@nightmared nightmared force-pushed the matrix-perform-edits branch from d1b0836 to ba4ba41 Compare November 8, 2020 17:05
@codeclimate
Copy link

codeclimate bot commented Nov 8, 2020

Code Climate has analyzed commit ba4ba41 and detected 0 issues on this pull request.

View more on Code Climate.

@42wim 42wim merged commit 6623599 into 42wim:master Nov 13, 2020
@42wim
Copy link
Owner

42wim commented Nov 13, 2020

Thanks 👍

@nightmared nightmared deleted the matrix-perform-edits branch November 14, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants