Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): 修复 tabs 组件选中下划线在初始化时会从最左面移到目标位置的问题 #649

Merged
merged 1 commit into from
May 31, 2023

Conversation

shadowings-zy
Copy link
Contributor

@shadowings-zy shadowings-zy commented May 31, 2023

在 vant 以及 antd 等组件中,初始化 tab 组件后,选中下划线会直接定位到选中的 tab 下面:
vant

而在 react-vant 中,选中下划线会从最左面移到选中 tab 下面,与 vant 交互不一致,看起来像是过早展现并加载了下划线的动画。
react-vant

该 PR 修复了这个问题,让 react-vant 的 tab 选中下划线的交互和 vant 等主流移动端组件库一致。

cc @3lang3

@github-actions
Copy link

PR preview has been successfully built and deployed to https://react-vant-pr-649.surge.sh.

@3lang3 3lang3 merged commit f4c8318 into 3lang3:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants