Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Sticky): 修复offsetTop通过 props传入时动态更新后，onScroll方法取offset仍为初始值的问题 #639

Merged
merged 1 commit into from
May 8, 2023
Merged

fix(Sticky): 修复offsetTop通过 props传入时动态更新后，onScroll方法取offset仍为初始值的问题 #639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/react-vant/src/components/sticky/Sticky.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { CSSProperties, useRef, useMemo } from 'react'
import React, { CSSProperties, useRef, useMemo, useCallback } from 'react'
import clsx from 'clsx'

import useScrollParent from '../hooks/use-scroll-parent'
Expand Down Expand Up @@ -80,7 +80,7 @@ const Sticky: React.FC<StickyProps> = props => {
}
}

const onScroll = () => {
const onScroll = useCallback(() => {
if (!root.current || isHidden(root.current)) {
return
}
Expand Down Expand Up @@ -119,9 +119,12 @@ const Sticky: React.FC<StickyProps> = props => {
}
updateState(newState)
emitScroll(scrollTop, newState.fixed)
}
}, [offset])

useEventListener('scroll', onScroll, { target: scrollParent })
useEventListener('scroll', onScroll, {
target: scrollParent,
depends: [offset],
})
useVisibilityChange(root, onScroll)
useUpdateEffect(() => {
props.onChange?.(state.fixed)
Expand Down