Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctffind_runner fails with tiff images #728

Closed
gruchalla opened this issue Jan 25, 2021 · 1 comment
Closed

ctffind_runner fails with tiff images #728

gruchalla opened this issue Jan 25, 2021 · 1 comment

Comments

@gruchalla
Copy link

CTFFIND can process tiff images. Relion launches CTFFIND and executes correctly, but the ctffind_runner fails with warning messages:

WARNING: skipping, since cannot get CTF values for images/4_bl.000.tif

The issue is cttfind_runner is hard-coded to strip ".mrc" off the image filenames when looking for ctf files, so it cannot find them. For the above example, instead of looking for the 4_bl.000.ctf that ctffind created, it is looking for 4_bl.000.tif.ctf which doesn’t exist. See ctffind_runner.cpp line 252:
FileName fn_microot = fn_mic_ctf_given_all[imic].without(".mrc");
and line 431:
FileName fn_microot = fn_micrographs_ctf_all[imic].without(".mrc")

replacing these lines with
FileName fn_microot = fn_mic_ctf_given_all[imic].withoutExtension();
and
FileName fn_microot = fn_micrographs_ctf_all[imic].withoutExtension();

respectively, appears to resolve the problem with tiff images.

@biochem-fan
Copy link
Member

This makes sense. I applied your suggestion in commit 319cd1b. Thank you very much for feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants